[MPlayer-dev-eng] [PATCH] Direct3D beautify info/error messages

Diego Biurrun diego at biurrun.de
Wed Feb 4 19:53:11 CET 2009


On Wed, Feb 04, 2009 at 08:33:01PM +0200, Georgi Petrov wrote:
> On Wed, Feb 4, 2009 at 8:29 PM, Reimar Döffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > On Wed, Feb 04, 2009 at 08:26:17PM +0200, Georgi Petrov wrote:
> >> So you suggest to just use \n instead of \r\n, right? I'll do it if
> >> this is the preferred way. Ok?
> >
> > Yes.
> 
> I attach the corrected patch.
> 
> --- libvo/vo_direct3d.c	(revision 28462)
> +++ libvo/vo_direct3d.c	(working copy)
> @@ -383,19 +383,19 @@
>  
>      mp_msg(MSGT_VO, MSGL_V,
> -           "<vo_direct3d><INFO>New backbuffer: Width: %d, Height:%d. VO Dest Width:%d, Height: %d\n",
> +           "<vo_direct3d>New backbuffer (%dx%d), VO (%dx%d).\n",

I'd drop the period here, there is no verb, this is not a complete
sentence.

Other than that, this patch is OK to commit.

Diego



More information about the MPlayer-dev-eng mailing list