[MPlayer-dev-eng] [PATCH] '-priority' support on OS/2

[Diego Biurrun]

On Thu, Feb 05, 2009 at 02:09:49AM +0900, KO Myung-Hun wrote:
>
> Ah, so ? Then codes can be much simpler.

First off: This is a much better way to implement the solution!

> I attach the updated patch.
>
> --- Makefile	(revision 28306)
> +++ Makefile	(working copy)
> @@ -433,6 +433,7 @@
> 										 stream/realrtsp/xbuffer.c \
> 
>  SRCS_COMMON-$(PNG) 				  += libmpcodecs/vd_mpng.c
> +SRCS_COMMON-$(PRIORITY)				 += osdep/$(PRIORITY_C)
>  SRCS_COMMON-$(PVR) 				  += stream/stream_pvr.c
>  SRCS_COMMON-$(QTX_CODECS)			  += libmpcodecs/ad_qtaudio.c \

Suddenly this file is full of tabs, what happened?

> --- mplayer.c	(revision 28306)
> +++ mplayer.c   (working copy)
> @@ -88,8 +88,8 @@
>  
> -#if defined(__MINGW32__) || defined(__CYGWIN__)
> -char * proc_priority=NULL;
> +#ifdef CONFIG_PRIORITY
> +#include "osdep/priority.h"
>  #endif

I think it is safe to leave out the #ifdef.

> --- osdep/priority-win.c    (revision 0)
> +++ osdep/priority-win.c    (revision 0)

> --- osdep/priority-os2.c    (revision 0)
> +++ osdep/priority-os2.c    (revision 0)

I have the impression that this could be one file.

> --- osdep/priority.h    (revision 0)
> +++ osdep/priority.h    (revision 0)
> @@ -0,0 +1,32 @@
> +/*
> + * priority.h : header for implementation of '-priority'

Leave out the filename, same above.

> + * You should have received a copy of the GNU General Public License along
> + * with MPlayer; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + *
> + */

Stray empty line, same above.

> +
> +#ifndef MPLAYER_PRIORITY_H
> +#define MPLAYER_PRIORITY_H
> +
> +extern char *proc_priority;
> +
> +void set_priority(void);
> +
> +#endif

Add a comment to the #endif.

> --- cfg-common-opts.h   (revision 28306)
> +++ cfg-common-opts.h   (working copy)
> @@ -3,6 +3,10 @@
>  
> +#ifdef CONFIG_PRIORITY
> +#include "osdep/priority.h"
> +#endif

see above

> --- mencoder.c	(revision 28306)
> +++ mencoder.c  (working copy)
> @@ -143,8 +143,8 @@
>  
> -#if defined(__MINGW32__) || defined(__CYGWIN__)
> -char * proc_priority=NULL;
> +#ifdef CONFIG_PRIORITY
> +#include "osdep/priority.h"
>  #endif

again

Diego