[MPlayer-dev-eng] [PATCH] '-priority' support on OS/2

[KO Myung-Hun]

Hi/2.

Reimar Döffinger wrote:
> On Thu, Feb 05, 2009 at 01:04:30AM +0900, KO Myung-Hun wrote:
>   
>> +#define _UWIN 1  /*disable Non-underscored versions of non-ANSI functions as otherwise int eof would conflict with eof()*/
>>     
>
> Huh? Which "int eof"?
>
>   

It's from mplayer.c. I'm not familiar with Win32 programming. So I 
cannot be sure that is not necessary. If someone familiar with Win32 say 
it's not necessary, I would remove it.

>> +    if(init_timer_res)
>> +        // request 1ms timer resolution
>> +        timeBeginPeriod(1);
>>     
>
> This has nothing to do with process priority (even though it is somewhat
> related to the scheduler) and thus does not belong here.
>
>   

This is also from mplayer.c. Win32 codes use it in priority setting 
block only in mplayer.c. That is, it's for the compatibility with 
original codes.

>> +void uninit_priority(int uninit_timer_res)
>> +{
>> +    if(uninit_timer_res)
>> +        timeEndPeriod(1);
>> +}
>>     
>
> as a consequence, uninit_priority is not needed, and e.g. set_priority would
> seem like a more appropriate name.
>   

I agree. But in mplayer.c, timeEndPeriod() is called when exiting. So 
it's needed. At first, I also named i t 'set_priority' exactly. BTW I 
found timeEndPeriod() call. After all, I introduce init_priority() and 
uninit_priority().

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr