[MPlayer-dev-eng] [PATCH] Fix 'make distclean'

Diego Biurrun diego at biurrun.de
Tue Feb 3 13:32:01 CET 2009


On Tue, Feb 03, 2009 at 02:02:37AM +0200, Georgi Petrov wrote:
> On Tue, Feb 3, 2009 at 1:53 AM, Reimar Döffinger
> <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > On Tue, Feb 03, 2009 at 12:31:43AM +0100, Diego Biurrun wrote:
> >> You have to run configure again after distclean.  Everything else is
> >> undefined behavior.
> >
> > I'd be thankful if you could find time to make things more reliable, two suggestions:
> > 1) Ignore rm failure
> 
> This one will be enough to perform correct distclean at least on my
> environment.

No, it would *not* be correct in your environment as it would not
remove the binaries as it is supposed to.  It might run without
returning an error.  In this case, this is opposite from running
correctly.

Errors are not to be ignored.  The fact that distclean printed an error
should tell you something.

Diego



More information about the MPlayer-dev-eng mailing list