[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 6

[Carl Eugen Hoyos]

Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

[...]

> > +    if (vo_config_count)
> > +        return 0;
> 
> Still wrong. I won't review any further version unless they were tested
> (preferably with valgrind to detect leaks) with -fixed-vo and different video
> format files.

I forgot to mention that I tested -fixed-vo -vo vdpau with different video
format files with different resolutions before sending the last patch not seeing
any difference to -vo gl and -vo xv.
I tested now again with valgrind and vdpau loses slightly less bytes then xv and
gl (~3100 vs ~3500).
Anything else I can do to convince me it doesn't work correctly?

[...]

> > +    vdp_st = vdp_presentation_queue_display(vdp_flip_queue, output_surface,
> > +                                            FFMIN(max_width,
FFMAX(out_rect.x1, out_rect_vid.x1)),
> > +                                            FFMIN(max_width,
FFMAX(out_rect.y1, out_rect_vid.y1)),
> 
> As noticed on the forums, there are quite a few width/height messups as
> this one.

Thank you, I had only found the other one.

I'll work on the return strings and send a new patch, thank you for reviewing,
Carl Eugen