[MPlayer-dev-eng] [PATCH] Fix 'make distclean'

[Diego Biurrun]

On Tue, Feb 03, 2009 at 01:35:26AM +0200, Georgi Petrov wrote:
> On Tue, Feb 3, 2009 at 1:31 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Feb 03, 2009 at 01:25:48AM +0200, Georgi Petrov wrote:
> >> The problem is that is for some reason you type "make" after the first
> >> "make distclean" and there is a mplayer subdirectory, the tree is left
> >> in unusable state. This "make" creates wrong help_mp.h, but further
> >> make distcleans can't clean it, because they fail at rm -f mplayer
> >> because mplayer is directory and the configure isn't run to make it
> >> "rm -f mplayer.exe".
> >
> > You have to run configure again after distclean.  Everything else is
> > undefined behavior.
> 
> Ok, isn't this decision wrong by design? I see what the failure is,
> but isn't make distclean always (philosophically) guaranteed to work?
> And the change is trivial I think, but I leave to you to decide
> whether to change it or leave it this way.

No, it is impossible.  distclean depends on system-specific information
that only configure can provide.  You cannot run it twice and expect it
to work correctly.

Diego