[MPlayer-dev-eng] [PATCH] internal libdvdcss for OS/2

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Thu, Jan 29, 2009 at 04:40:45PM +0900, KO Myung-Hun wrote:
>   
>> I already sent this patch to the upstream, but I've not got any response
>> from them.
>>
>> So I send this here directly.
>>
>> Any comments ?
>>     
>
> I pinged some of the videolan guys on IRC, xtophe reacted.  Try pinging
> them again, possibly with an updated patch, over on libdvdcss-devel.
>
> That said, I will not accept libdvdcss patches.  We got rid of all our
> local patches, I plan to keep it that way.
>
>   
>> --- libdvdcss/device.c  (revision 28306)
>> +++ libdvdcss/device.c  (working copy)
>> @@ -93,6 +99,14 @@
>>  static int aspi_read_internal  ( int, void *, int );
>>  #endif
>>  
>> +#ifdef SYS_OS2
>>     
>
> You can save two lines here with #elif, not that it changes much..
>
>   
>> @@ -270,6 +314,33 @@
>>  
>> +        rc = DosDevIOCtl(
>> +                ( HFILE )-1, IOCTL_DISK, DSK_GETDEVICEPARAMS,
>> +                &param, sizeof( param ), &ulParamLen,
>> +                &data, sizeof( data ), &ulDataLen );
>>     
>
> This looks like one of your weird indentation ideas and does not match
> surrounding code style.
>   

Ok, I see. I'll try to ping the upstream again.

Thanks for your helps. ^______^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr