[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 6

[Diego Biurrun]

On Sat, Jan 31, 2009 at 11:47:22PM +0100, Carl Eugen Hoyos wrote:
>
> Please comment, Carl Eugen

It would help if you could name your patches something.diff.

There is still some trailing whitespace.

> --- libvo/vo_vdpau.c	(revision 0)
> +++ libvo/vo_vdpau.c	(revision 0)
> @@ -0,0 +1,699 @@
> +/*
> + * VDPAU Renderer for MPlayer.
> + * VDPAU with X11 interface.

stray periods

This looks like a strange description, isn't this a vo driver?

> + * Actual decoding and presentation are implemented here.
> + * All necessary frame information are collected through

The word "information" has no plural.

> +#ifdef CONFIG_GUI
> +#include "gui/interface.h"
> +#endif

Probably pointless #ifdef, but does the GUI code in this file make
any sense?

> +/*
> + * X11 specific.

useless period

> +        xswa.background_pixel = 0;
> +        xswa.border_pixel = 0;

align

> +    // video width and height
> +    vid_width = width;
> +    vid_height = height;

ditto

> +    index_data_size_required = 2*w*h;
> +    if (index_data_size < index_data_size_required) {
> +        index_data = realloc(index_data, index_data_size_required);
> +        index_data_size = index_data_size_required;

ditto

> +            index_data[i*2*w + j*2] = src[i*stride+j];
> +            index_data[i*2*w + j*2 + 1] = -srca[i*stride+j];

ditto

Diego