[MPlayer-dev-eng] [PATCH] Screen blanking prevention for Maemo

[Reimar Döffinger]

On Sun, Dec 20, 2009 at 10:18:23PM +0100, Diego Biurrun wrote:
> On Sun, Dec 20, 2009 at 09:03:20PM +0200, Jan Knutar wrote:
> > This patch prevents the screen from switching off and the device 
> > entering lower power state on Maemo devices (Nokia Nxxx).
> > 
> > The original code was most likely written at or around MPlayer 1.0rc1 
> > timeframe by Siarhei Siamashka, and lived in the maemo port of MPlayer 
> > (which is now effectively abandoned/obsolete). Whether it was ever 
> > submitted upstream I don't know.
> > 
> > It was fished out of the old rc1 maemo mplayer by Sampo Savola, who 
> > added it to a new maemo "port" based on a recent-ish svn of MPlayer.
> > 
> > I fished it out of his port and made it #ifdef'd maemo, patch against 
> > today's svn.
> > 
> > Any issues with this living in upstream MPlayer?
> 
> Hmm, Reimar?  You handle all the screensaver stuff..

Well, assuming it is not possible to just use -heartbeat-cmd efficiently,
and of course mentioning my complete lack of knowledge for that platform:
I'd say drop the osso_display_state_on part, it looks like "in case something
goes wrong" hack which should be avoided in SVN code.
Also if in any way possible (and I am quite certain of it) it should just reuse
the timing code of heartbeat-cmd - admittedly the same applies to xscreensaver_heartbeat