[MPlayer-dev-eng] [PATCH] Screen blanking prevention for Maemo

[Siarhei Siamashka]

On Sunday 20 December 2009, Jan Knutar wrote:
> This patch prevents the screen from switching off and the device
> entering lower power state on Maemo devices (Nokia Nxxx).
>
> The original code was most likely written at or around MPlayer 1.0rc1
> timeframe by Siarhei Siamashka, and lived in the maemo port of MPlayer
> (which is now effectively abandoned/obsolete).

Yes, now it is as obsolete as the older maemo devices. And it will die as
soon as people stop using such old hardware.

> Whether it was ever submitted upstream I don't know.

http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-May/051710.html

Almost all the changes have been submitted upstream (with different level of
success). Some of them got accepted, some problems got resolved in a 
different/more kosher way by upstream developers, some patches were rejected
or stalled. The only patches which were never submitted, depended on the ones
which got rejected IIRC, but I could have missed something. Using SVN as a
version control system was not very suitable for maintaining a moderately
sized patchset, hence all the mess. 

> It was fished out of the old rc1 maemo mplayer by Sampo Savola, who
> added it to a new maemo "port" based on a recent-ish svn of MPlayer.
>
> I fished it out of his port and made it #ifdef'd maemo, patch against
> today's svn.
>
> Any issues with this living in upstream MPlayer?

Based on the outcome of the previous discussion, the main objection is that it
is a bad idea to litter mplayer codebase with platform specific hacks. There
is also a bug in maemo bugzilla: https://bugs.maemo.org/show_bug.cgi?id=1460

I guess it's a responsibility of a package maintainer to apply such platform
specific patches (especially trivial ones) so that the end result just works
and is usable.

-- 
Best regards,
Siarhei Siamashka