[MPlayer-dev-eng] [patch] play and seek files inside multivolume uncompressed rar files

[compn]

On Fri, 18 Dec 2009 10:11:39 +0100, Diego Biurrun wrote:
>On Fri, Dec 18, 2009 at 07:44:57AM +0100, Reimar Döffinger wrote:
>> On Thu, Dec 17, 2009 at 09:39:03PM -0500, compn wrote:
>> > On Tue, 08 Dec 2009 20:12:02 +0100, Emiel Neggers wrote:
>> > >On Mon, 2009-12-07 at 00:15 -0500, compn wrote:
>> > >> On Mon, 30 Nov 2009 20:54:04 +0100, Emiel Neggers wrote:
>> > >Thanks for testing. Included is an updated version that works on
>> > >windows/mingw, and hopefully also fixes all of the issues that Diego
>> > >addressed in his mail from last Sunday.
>> > >
>> > >Specifically:
>> > >  * changed license to gpl v2+ (copied from another file in mplayer)
>> > >  * 4-space indentation
>> > >  * removed commented-out code
>> > >  * replaced _UNRAR_H with MPLAYER_UNRAR_H
>> > >  * do not use _t namespace for rar_archive
>> > >  * replaced naming_scheme = NAMING_OLD/NAMING_NEW with
>> > >      new_naming_scheme = 1/0
>> > >  * add support for rar archives that run into .s00 and up
>> > >  * set O_BINARY flag on open files for compatibility with MinGW/Windows
>> > >
>> > >Please let me know if further changes are needed.
>> > 
>> > i plan to apply this unless there are any objections.
>> 
>> Well, there are at least some minor things like the comments should be
>> doxygen-compatible, it should use e.g. AV_RL32 instead of reimplementing
>> it as UINT32 macro etc.
>
>And more things like inconsistent, non-K&R formatting, illegal
>identifiers, probably more things that an in-depth review might uncover.
>Please check such things yourself before you threaten to apply a patch.

was more of a bluff + attention grabber.

>However, I still wonder if it is MPlayer's job to do rar decompression.

this patch only works on uncompressed rar. perhapse you mean rar
extraction? anyways, it seems the same as playing from .iso or .bin to
me. at least there are probably more of these multivolume rars than
iso/bin anymore in the wild.

-compn