[MPlayer-dev-eng] [PATCH] Fix warnings from missing includes
Diego Biurrun
diego at biurrun.de
Mon Dec 14 12:55:11 CET 2009
On Wed, Dec 09, 2009 at 06:41:03PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 09 December 2009 at 18:31, Diego Biurrun wrote:
> > On Thu, Dec 03, 2009 at 10:54:04AM +0100, Peter Hjalmarsson wrote:
> > > * QA Notice: Package has poor programming practices which may compile
> > > * fine but exhibit random runtime failures.
> > > * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> > > * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> > > * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> > > * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> > > * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> > > * tremor/misc.h:188: warning: implicit declaration of function 'abs'
> > > * tremor/misc.h:188: warning: implicit declaration of function '_ilog'
> > >
> > > These warnings are because of two missing includes, the attached patch
> > > fixes these.
> >
> > We generally try to avoid patching internal copies of external
> > libraries. Then again, this is trivial enough to just apply anyway.
> > Thoughts?
>
> I used to have a similar patch in my tree, I'll look at it and report
> back when I get home.
.. ping ..
I applied the patch for now, it was trivial enough.
Diego
More information about the MPlayer-dev-eng
mailing list