[MPlayer-dev-eng] [PATCH] -geometry support in vo_corevideo

[Tim Wojtulewicz]

On Dec 5, 2009, at 4:46 PM, Reimar Döffinger wrote:

> On Sun, Dec 06, 2009 at 12:21:41AM +0100, Adrian Stutz wrote:
>> On Sat, Dec 5, 2009 at 11:05 PM, Tim Wojtulewicz <timwoj at ieee.org> wrote:
>> 
>>> I switched to use setFrame and did a bit of testing with it.  I can't get
>>> the thing to move from under the menu bar until I pass ~300 for the y value.
>>> I'm not entirely sure why.  Once I get to that value, the window jumps way
>>> down the screen.  I'll play with it a bit more and see if I can get it to
>>> agree with me.
>>> 
>>> Could we possibly add a note to the docs for -geometry that says something
>>> like "For corevideo, the top-left corner is considered the bottom of the
>>> menu bar"?
>>> 
>> 
>> Attached patch works well for me. Could you give it a try to see if you
>> still have your issue with it?
>> 
>> I don't have a strong opinion against taking the menu bar into account. So,
>> if nobody objects, I'll commit the patch in a few days.
> 
> Have you tested with multi-monitor setups? vo_screenheight should have the correct
> value for that, I do not know if visible frame will, not do I know if the menu
> bar is always displayed on all monitors.

That patch fixes my problem with setFrame.  If you apply it, don't forget the patch to the man page too.  If I remember, I can hook up a second monitor to my macbook in the next few days and try it out.  As far as I know, the menu bar is only displayed on the primary monitor, but it's been a long time since I used it in a setup like that.

Thanks, this fixes a long-standing annoyance I've had with mplayer on OS X.