[MPlayer-dev-eng] [PATCHES] SuperH fixes and VEU vidix improvements

Magnus Damm magnus.damm at gmail.com
Wed Dec 2 03:28:49 CET 2009


On Wed, Dec 2, 2009 at 2:53 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Tue, Dec 01, 2009 at 10:39:00PM +0900, Magnus Damm wrote:
>> Hi everyone,
>>
>> Here comes patches with SuperH build fixes and some VEU vidix driver
>> improvements. Please apply straight away or let me know how you want
>> me to rework things.
>
> Well, at least the second patch no longer closes the file and thus leaks a file descriptor...

Yeah, good point. I'll add a close() to the destroy callback and
resend the last one.

If we're aiming at better code then it would be pretty nice to get a
private data pointer passed along with the vidix callbacks. That way
the vidix drivers can avoid using globals for everything...

Thanks!

/ magnus



More information about the MPlayer-dev-eng mailing list