[MPlayer-dev-eng] [PATCH] Add support for directory-wide configuration overrides V1.3

[Reimar Döffinger]

On Mon, Aug 31, 2009 at 10:32:19AM +0300, Christian P. Schmidt wrote:
> Diego Biurrun wrote:
> > On Sun, Aug 30, 2009 at 03:04:12PM +0300, Christian P. Schmidt wrote:
> >> --- mplayer.c	(revision 29565)
> >> +++ mplayer.c	(working copy)
> >> @@ -916,10 +917,26 @@
> >>  
> >> +    if (use_filedir_conf)
> >> +    {
> > 
> > if (use_filedir_conf) {
> 
> That breaks the style currently in use in the function. Is it ok to mix
> styles?

Sorry you already got the cosmetic comments, the more significant is
that there is already code to find the start of the file name a few
lines below, you should move that up and reuse instead of duplicating
it (so I'll only have to fix one place once I find the time to test on
Windows).