[MPlayer-dev-eng] [PATCH] add sh_common

[Uoti Urpala]

On Thu, 2009-08-27 at 10:40 +0200, Reimar Döffinger wrote:
> there is quite a bit of duplicated declaration and also some things like
> extradata/codecdata unfortunately got different names.
> Thus I suggest adding a SH_COMMON macro to declare common stuff and

IMO just having fields with the same names and types is not a reason to
unify them. Some of the similarly named fields like pts are also used
differently (it's questionable whether the pts field as currently used
should be in the video struct at all).

> a corresponding struct so it is possible to access these without knowing
> which one it is.

Code doing unified handling of some field over all the struct types
could be a reason to implement a shared prefix, but without any examples
of what you'd actually like to do it's impossible to say whether that
would be an appropriate solution in this case.