[MPlayer-dev-eng] [PATCH] use standard aspect functions for vo_quartz

[Guillaume POIRIER]

Hello,

On Fri, Aug 28, 2009 at 10:55 AM, Reimar
Döffinger<Reimar.Doeffinger at gmx.de> wrote:
> On Fri, Aug 28, 2009 at 10:15:41AM +0200, Guillaume POIRIER wrote:
>> 2009/8/28 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
>> > vo_quartz currently reimplements the whole aspect handling (and probably
>> > badly, too), attached patch changes it to use the standard functions
>> > where obvious.
>> > I realized there are some other things missing like -geometry support
>> > that at least after this change should work for specifying size, but
>> > position is ignored.
>> > Panscan is also still handled in an ugly way that can only work with
>> > fullscreen windows and even there leaves ugly artefacts on the
>> > neighbouring displays if there are any I think.
>>
>> Tested and works as expected on my machine.
>> Feel free to do whatever you want with vo_quartz: this VO won't be
>> developed further anyway since it uses Carbon, which isn't 64-bits
>> compatible. That means that it won't build by default on Snow Leopard.
>
> Btw. will the Carbon headers still be usable? Because Apple still hasn't
> managed to include a handful of defines for the keycodes in Cocoa, so
> the only place to get them from is a Carbon header.
> Or do we have to define them all by ourselves (duplicating that code
> between vo_quartz and vo_corevideo IMO is not acceptable, as well as the
> current mess with using "magic" numbers in corevideo that just fell out
> from somewhere).

I must admit I don't know, but at least on Leopard, they are still
available. Do you mean that I should switch to Snow Leopard to find
out?

Looks like the good excuse I was waiting for to purchase that software... ;-)

Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Pablo Picasso  - "Computers are useless. They can only give you
answers." - http://www.brainyquote.com/quotes/authors/p/pablo_picasso.html