[MPlayer-dev-eng] [PATCH] AVParser for audio support

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Aug 26 21:52:48 CEST 2009


On Wed, 2009-08-26 at 19:42 +0200, Reimar Döffinger wrote:
> Hello,
> probably quite some room for improvements, though I think it is a good
> step forward even if it is still a bit ugly.
> It allows to use ffdca and ffac3 with the native AVI and MPEG demuxers.

IMO that code in ds_add_packet is quite ugly. How about doing the
parsing in ad_ffmpeg? Is there a reason to expect a practical benefit
from doing it elsewhere? Even if it's needed for multiple uses either
adding a separate parsing function or doing parsing in demuxer.c
functions when taking packets _out of_ the queue (so the information
from the demuxer is kept intact in the queue) could be preferable.

The new version you just posted fixes the pos/pts field loss that
happened due to creating new packets, but doing special-case copies of
those fields is still ugly.




More information about the MPlayer-dev-eng mailing list