[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Reimar Döffinger]

On Sat, Aug 22, 2009 at 07:17:05PM +0200, Francesco Lavra wrote:
> If my patches are applied, the teletext stuff will be only in
> libmpcodecs/dec_teletext.{c,h}. libmpdemux/demux_ts.c will have only the
> code to detect teletext streams and pass them to the teletext decoder
> (if you want, the functions init_dvb_teletext() and
> deinit_dvb_teletext() can be moved to dec_teletext.c as well).

It should not use a single line of code more than what is in demux_ts.c currently.
Well, that's not quite true.
I think it will be easier to test with the libavformat demuxer (-demuxer lavf),
attached is a patch this is a stub of what I had in mind.
Though I admit that treating it as subtitle might be a bit questionable and
have unexpected issues, and there might be less ugly ways to do it.
But it will need a lot of convincing for me to agree with a solution that
does not work with -demuxer lavf (and I don't think ffmpeg devels will allow
you to add much code beyond what my stub does to FFmpeg).

> > Btw do you have a good, small, known working example file for DVB teletext?
> > Either I am doing something wrong or the one I caputered is not really working...
> 
> Teletext decoding works only from either a TV demuxer (demuxer->type ==
> DEMUXER_TYPE_TV) or a DVB stream (demuxer->stream->type ==
> STREAMTYPE_DVB), so it's not possible to decode it from a file.

That's a really huge design bug then IMO.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvbtt_stub.diff
Type: text/x-diff
Size: 2885 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090822/397d2b0e/attachment.diff>