[MPlayer-dev-eng] [PATCH] Add DVB teletext support

[Reimar Döffinger]

On Sat, Aug 22, 2009 at 05:20:35PM +0200, Francesco Lavra wrote:
> Your patch treats teletext data as if it were subtitles, putting it in
> the demuxer stream dedicated to subtitles. But teletext in MPlayer is
> handled separately from subtitles, and its decoder has a different
> interface than that of subtitles decoders (see update_subtitles() vs
> update_teletext()); that's why in my patch teletext is decoded without
> use of demuxer streams, calling directly teletext_control() instead.

Not generating a subtitle stream but instead doing the decoding in the
stream IMO was a serious design mistake, otherwise the code to add this
support could be quite a bit smaller.

> If teletext data were treated as subtitles, update_subtitles() should
> decode it via the teletext decoder interface, but displaying teletext on
> the screen would still be taken care of by update_teletext(). Is that
> what you want?

Well, I mostly want the teletext stuff out of stream/libmpdemux where it
just does not belong.
Which if done well should have the side effect that the decoding for
the vbi and DVB can use basically the same code, and if e.g. mkv adds
teletext support it you would only have to change demux_mkv or demuxe_lavf
to support it.
Btw do you have a good, small, known working example file for DVB teletext?
Either I am doing something wrong or the one I caputered is not really working...