[MPlayer-dev-eng] [PATCH] ass.c: fix NULL pointer dereference on broken ass header

Ivan Kalvachev ikalvachev at gmail.com
Fri Aug 14 00:34:04 CEST 2009


On 8/13/09, Andrew Savchenko <bircoph at gmail.com> wrote:
> On Thursday 06 August 2009, Andrew Savchenko wrote:
>> Hello,
>>
>> this is bug reported by my friend (in Russian).
>> If header of Events section doesn't contain Format, mplayer
>> crashes. Real life example is attached (it is truncated, but
>> still essential).
>>
>> Fix is rather trivial. For now this is fallback for reasonable
>> defaults when format can't be parsed.
>
> No comments?
> I appreciate movemet towards external libass, but until then bugs
> and especially crashes should be fixed.
>
> Will apply in a week if no objections.

I think one week is reasonable period, there is no reason
to wait for another, especially if you commit it yourself
and thus take responsibility for it.

btw, do you know is this bug exist and/or is fixed in the
external libass?



More information about the MPlayer-dev-eng mailing list