[MPlayer-dev-eng] Question on implementing 7.1 channel support

[Jason Tackaberry]

On Mon, 2009-08-10 at 18:05 -0400, Jason Tackaberry wrote:
> In light of that, would the preferred implementation be:
> 
>      1. the smallest patch, in which the code that reorders 6 channels
>         also accepts 8 channels while ignoring the last 2 channels; or
>      2. adding all the AF_CHANNEL_LAYOUT_*_8CH_DEFAULT defines, a new
>         array channel_layout_mapping_8ch in reorder_ch.c, and the
>         necessary case statements in reorder_channel() working on
>         AF_CHANNEL_LAYOUT_7_1_* values.  This might be technically more
>         correct, and adds the plumbing needed if ever we do need to
>         support a completely different 8ch layout, but as it stands
>         right now would be overkill.

Ignore me while I talk to myself ...

After some consideration, #2 is the sanest implementation.  Otherwise
the reorder code would have to accommodate a lot of 8 channel
configurations that just aren't used.