[MPlayer-dev-eng] about log2 replacement

[Uoti Urpala]

On Mon, 2009-08-10 at 12:30 +0800, Chang Chen wrote:
> In r19395 of libavutil/internal.h, alexc added a inline function for
> log2.
> 
>  
> 
> ~~log2~~ isn't c99 standard, but it is defined a macro with build flag
> -std=gnu99.

It is standard.

> ffmpeg use -std=c99,  so this works, but mplayer use -std=gnu99, so
> build is broen

Not only is the function standard, but the configure script checks
whether it exists and sets the HAVE_LOG2 variable accordingly, so
compilation should work as long as the flags during the test and use are
the same. Also it's been a month since that change and other people
haven't reported related problems.

> any suggestion for how to fix this issue?

What exactly is the problem you have? As described above -std=c99 vs
-std=gnu99 should not cause any problems.