[MPlayer-dev-eng] [PATCH] Fix incorrect channel ordering for various codecs

Jason Tackaberry tack at urandom.ca
Mon Aug 10 02:05:01 CEST 2009


On Mon, 2009-08-10 at 02:54 +0300, Uoti Urpala wrote:
> Perhaps it would be best to first verify whether there's some reason not
> to change this in FFmpeg before changing MPlayer to assume such
> behavior.

The channel order for AAC decoding isn't an accident at least, as it's
explicitly defined in libavcodec/aac.c.  So it's safe to say that (with
these changes) MPlayer is conforming to ffmpeg's documented order for
AAC decoding, as opposed to a fluke or bug in ffmpeg.

(Note that Vorbis is in the same situation too.)

Now, it might well be true that ffaac and vorbis should be updated to be
more internally consistent.  But ffmpeg is a code base I am much less
familiar with, and the barrier to entry is higher if I'm the one doing
that leg work, to the extent that (knowing myself) it might not get
done.

So, hopefully you guys don't make that a prerequisite to merging these
fixes.

Cheers,
Jason.




More information about the MPlayer-dev-eng mailing list