[MPlayer-dev-eng] [PATCH] Dolby TrueHD support for mkv demuxer

[Aurelien Jacobs]

On Thu, Aug 06, 2009 at 10:24:57PM +0300, Uoti Urpala wrote:
> On Thu, 2009-08-06 at 19:38 +0200, Aurelien Jacobs wrote:
> > On Thu, Aug 06, 2009 at 05:31:48PM +0300, Uoti Urpala wrote:
> > > On Thu, 2009-08-06 at 14:25 +0200, Aurelien Jacobs wrote:
> > > > On Thu, Aug 06, 2009 at 12:10:21AM +0300, Uoti Urpala wrote:
> > > > > On Wed, 2009-08-05 at 16:23 -0400, compn wrote:
> > > > > > now if we could just get the lavf mkv demuxer to handle
> > > > > > subtitles w/ mplayer, then we could stop maintaining this duplication
> > > > > > of code.
> > > > 
> > > > I already sent a simple patch for this long ago. It is attached again.
> > > 
> > > And it's still wrong and breaks stuff.
> > 
> > There is no know breakage with this patch !
> 
> That's just your lack of knowledge then.

Maybe because you didn't informed me ! I'm impatient to know !

> The part about it breaking the
> internal demuxer should be obvious.

And the fix which was already committed as r27529 is as obvious !

> > > Why do you insist on having the
> > > lavf demuxer munge the subtitles into that format nobody wants to use?
> > 
> > nobody ???
> 
> Yes. Maybe you want to force others into using it, but it seems you're
> not even really using it yourself.

Huh ! What makes you think so ?? I obviously use it !

> > This bitstream format won't change unless you propose a patch on ffmpeg-devel.
> > Whining on this list won't have any effect.
> 
> Your insistence has nothing to do with patches or lack of them, and
> claiming that is dishonest on your part.

Right. It's not only about patches. It has to come with good argument.
But I won't prevent any change in lavf demuxer, as long michael is OK with it.
Anyway, if you are interested about this, continue the disscussion on
ffmpeg-devel.

> To implement the export of the
> normal SSA format from Matroska would be trivial.

Sure. But it won't change the fact that MPlayer need a patch similar to what
I propose. If you change lavf mkv demuxer to export its raw pseudo-ASS
format, you will have to use a new codec ID. It won't be compatible
with CODEC_ID_ASS which is used by other demuxers. And MPlayer would still
have to support this CODEC_ID_ASS format.

> > Now there are only few possibilities for MPlayer:
> >  1) embrace ffmpeg bitstream format and use it (this is what my patch is
> >     about, and is quite simple)
> 
> That format sucks technically and is undesirable to have as MPlayer's
> internal format.

That's just laughable...

> >  2) disregard ffmpeg bitstream format, continue to use matroska internal
> >     format, and basically drop support of lavf in MPlayer.
> 
> Since SSA/ASS subs do in practice not appear in containers other than
> Matroska other containers are not affected.

It appears in straight .ass files at least as much as in mkv files.

> >  3) support both format inside MPlayer (quite ugly and redundant, and will
> >     become useless when native mkv demuxer will be removed from MPlayer)
> 
> Given the current development of the lavf Matroska demuxer I doubt the
> internal Matroska demuxer will be removed any time soon.

Current development ?? What do you mean ?
I'm not aware of any bug repport or feature request... Can you point at
any ffmpeg issue ?

> > Now we have to choose one of those solution. I'm ready to implement either
> > 1) or 3) but only if I know that this solution will be accepted in svn
> > and won't be reverted by the arbitrary choice of a single person.
> 
> What you should do is implement exporting subtitles from lavf in a way
> that does not lose any information the original file had.

This has nothing to do with the fact that MPlayer need to support CODEC_ID_ASS
properly...

> > > > > The lavf Matroska demuxer doesn't export information needed for ordered
> > > > > chapter support either.
> > > > 
> > > > Neither does the native Matroska demuxer AFAIK, so what's your point ?
> > > 
> > > It does in git.
> > 
> > There is no MPlayer git repository.
> > Please stop using the name "MPlayer" for your own fork especially now that
> > it is obvious that your goals are diverging from MPlayer's one.
> 
> Who defines "MPlayer's goals"? People like you who don't work on
> MPlayer?

At least that's not me who defined the long term goal to drop native
demuxers in favor of lavf. I've agreed to this goal. And AFAIK, most
developers agreed to this.
To my knowledge, you are the only one actively working in the opposit
direction (by implementing new features in native demuxers).

> > If this patch annoys you regarding your fork, note that I didn't proposed
> > it for inclusion in you fork. Only in MPlayer repository. Feel free to
> > do whatever you want with your damn fork, except hindering MPlayer's
> > development.
> 
> The format you insist on sucks technically.

The format you insist on sucks technically.

Aurel