[MPlayer-dev-eng] [PATCH] Dolby TrueHD support for mkv demuxer

[Grigori Goronzy]

Aurelien Jacobs wrote:
> nobody ???
> Anyway, in case you didn't realize, ffmpeg settled on a bitstream to
> export ASS track (this is not especially related to the mkv demuxer).
> This bitstream format won't change unless you propose a patch on ffmpeg-devel.

Is there actually a container besides Matroska that embeds ASS/SSA and
is in active use?  To my knowledge not, and it won't change in the near
future either. So, why is the new bitstream format needed?

Besides, there are several problems with your patch and the format.
- The patch breaks the internal mkv demuxer.
- The ffmpeg format does not have the ReadOrder field, so you can't
check for duplicate events easily and your patch currently doesn't do
that at all.
- SSA/ASS timestamps have centisecond accuracy, while Matroska
timestamps usually have millisecond accuracy.  This might cause problems...

There IS breakage with this patch. A lot of it.

>  3) support both format inside MPlayer (quite ugly and redundant, and will
>     become useless when native mkv demuxer will be removed from MPlayer)
>

I've heard more than one person voice that the lavf demuxer has its
share of problems and isn't easy to understand or to work with.  And
from a user's POV, if I remember correctly, I had some problems with it
as well.

Grigori