[MPlayer-dev-eng] [PATCH] Dolby TrueHD support for mkv demuxer

[Diego Biurrun]

On Thu, Aug 06, 2009 at 05:31:48PM +0300, Uoti Urpala wrote:
> On Thu, 2009-08-06 at 14:25 +0200, Aurelien Jacobs wrote:
> > On Thu, Aug 06, 2009 at 12:10:21AM +0300, Uoti Urpala wrote:
> > > On Wed, 2009-08-05 at 16:23 -0400, compn wrote:
> > > > now if we could just get the lavf mkv demuxer to handle
> > > > subtitles w/ mplayer, then we could stop maintaining this duplication
> > > > of code.
> > 
> > I already sent a simple patch for this long ago. It is attached again.
> 
> And it's still wrong and breaks stuff. Why do you insist on having the
> lavf demuxer munge the subtitles into that format nobody wants to use?
> 
> > > The lavf Matroska demuxer doesn't export information needed for ordered
> > > chapter support either.
> > 
> > Neither does the native Matroska demuxer AFAIK, so what's your point ?
> 
> It does in git. Ordered chapter support is implemented on top of more
> general timeline support, which allows creating a continuous timeline
> from (parts of) multiple individual files. The implementation of that
> again shows why your munged format is a bad idea; absolute timestamps
> belong in top-level packet fields, not inside codec data.
> 
> > Moreover, I'm not aware of any sample making use of this feature...
> 
> I have seen quite a few.

Then why don't we have any in our samples collection? :)

Diego