[MPlayer-dev-eng] [PATCH] Allow -channels 8

[Uoti Urpala]

On Wed, 2009-08-05 at 16:15 -0400, Jason Tackaberry wrote:
> Hi,
> 
> The attached patch increases the maximum number of channels (as given to
> -channels) to 8.  New codecs such as TrueHD support up to 8 channels.

> --- cfg-common-opts.h   (revision 29476)
> +++ cfg-common-opts.h   (working copy)
> @@ -187,7 +187,7 @@
>         // force video/audio rate:
>         {"fps", &force_fps, CONF_TYPE_DOUBLE, CONF_MIN, 0, 0, NULL},
>         {"srate", &force_srate, CONF_TYPE_INT, CONF_RANGE, 1000, 8*48000, NULL},
> -       {"channels", &audio_output_channels, CONF_TYPE_INT, CONF_RANGE, 1, 6, NULL},
> +       {"channels", &audio_output_channels, CONF_TYPE_INT, CONF_RANGE, 1, 8, NULL},

This isn't enough. At least AF_NCH needs to be increased too for any
proper support of a larger channel count. Just increasing it is probably
OK, but some checking of the filters to make sure nothing breaks would
be preferable.

What about channel order? Is that handled correctly without changes?