[MPlayer-dev-eng] [PATCH] libbs2b: new api

[Andrew Savchenko]

On Wednesday 22 April 2009, Andrew Savchenko wrote:
> Hi,
>
> On Tuesday 21 April 2009, Diego Biurrun wrote:
> [...]
>
> > > > "else if" should be on one line.
> > >
> > > No, no, no. The idea is to keep all if statements at the
> > > same alignment level, otherwise it will be mess to read.
> > > Currently they have nice and easy-to-understand-the-code
> > > indentation. Statements are logically equal and there is no
> > > reason to accent one of them. You may consider this as swith
> > > statement for strings.
> > >
> > > Yes, I know this is not strict K&R indentation but sometimes
> > > logics should override common rules.
> >
> > I'm with Uoti on this one, just use standard K&R style.
>
> OK. And please, update DOCS/tech/svn-howto.txt to mention that
> K&R style is mandatory for all new code for MPlayer these days.
>
> > > --- DOCS/man/en/mplayer.1	(revision 29211)
> > > +++ DOCS/man/en/mplayer.1	(working copy)
> > > @@ -5067,11 +5067,27 @@
> > > +.RS
> > > +If fcut or feed options are specified together with
> > > profile, they
> >
> > a profile
>
> OK.
>
> Thank you all for review.
> New patches are attached.

Will apply in 5 days if there are no objections.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090428/3efcd8ef/attachment.pgp>