[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Apr 21 11:35:23 CEST 2009


On Mon, Apr 20, 2009 at 04:09:13PM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> 
> > On Sat, Apr 04, 2009 at 06:31:15PM +0200, Carl Eugen Hoyos wrote:
> > > 
> > > I'm still fighting rebuild duration (and I wonder which measure against 
> > > spurious rebuilds ever worked: It is broken since at least several 
> > > hundred revisions).
> > > Attached patch is not sufficient, but moves us in the right direction, 
> > > imo.
> > 
> > Even though we have addressed the spurious rebuild problems, I think
> > this patch is probably an improvement.
> 
> Reimar was against the idea of the patch, so I'd like to hear a positive comment
> from him before working on it.

Well, at least I think it should be
const char mplayer_version[] = VERSION;
I don't mind much, but I don't like it too much that the strings now
have to be created at runtime instead of being generated at
compile-time.



More information about the MPlayer-dev-eng mailing list