[MPlayer-dev-eng] [PATCH] libbs2b: new api

[Diego Biurrun]

On Tue, Apr 21, 2009 at 12:33:47AM +0400, Andrew Savchenko wrote:
> 
> On Monday 20 April 2009, Uoti Urpala wrote:
> > On Mon, 2009-04-20 at 22:45 +0400, Andrew Savchenko wrote:
> 
> > +            else
> > +            if (!strcmp(s->profile,"cmoy"))
> >
> > "else if" should be on one line.
> 
> No, no, no. The idea is to keep all if statements at the same 
> alignment level, otherwise it will be mess to read. Currently they 
> have nice and easy-to-understand-the-code indentation. Statements 
> are logically equal and there is no reason to accent one of them. 
> You may consider this as swith statement for strings.
> 
> Yes, I know this is not strict K&R indentation but sometimes logics 
> should override common rules.

I'm with Uoti on this one, just use standard K&R style.

> --- DOCS/man/en/mplayer.1	(revision 29211)
> +++ DOCS/man/en/mplayer.1	(working copy)
> @@ -5067,11 +5067,27 @@
> +.RS
> +If fcut or feed options are specified together with profile, they

a profile

Diego