[MPlayer-dev-eng] [PATCH] memory leak in vo_macosx

Guillaume POIRIER poirierg at gmail.com
Mon Apr 13 22:08:18 CEST 2009


Hi,

2009/4/9 Alexander Strange <astrange at ithinksw.com>:
> vo_macosx leaks ~80 bytes with each call to flip_page, because this line:
>        error = CVOpenGLTextureCacheCreateTextureFromImage(NULL,
> textureCache, frameBuffers[image_page], 0, &texture);
>
> overwrites 'texture' without freeing the old one first (checked with
> 'leaks'). I'm not sure when this started happening. Attached patch fixes it
> by releasing the old texture.

Patch applied: it does reduce leaks, but doesn't totally get rid of
all, as far as I can see.

Thanks!

Guillaume

-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Henny Youngman  - &quot;I told the doctor I broke my leg in two
places. He told me to quit going to those places.&quot; -
http://www.brainyquote.com/quotes/authors/h/henny_youngman.html



More information about the MPlayer-dev-eng mailing list