[MPlayer-dev-eng] [PATCH] fixing vf_sab

Diego Biurrun diego at biurrun.de
Mon Apr 13 10:58:13 CEST 2009


On Mon, Apr 13, 2009 at 03:08:22AM -0400, Alexander Strange wrote:
> 
> On Apr 12, 2009, at 8:09 PM, Michael Niedermayer wrote:
> 
> >On Wed, Apr 08, 2009 at 10:30:34PM -0400, Alexander Strange wrote:
> >>Currently -vf sab always crashes, because it calls sws_getContext  
> >>with no
> >>scaling algorithm in the flags.
> >>This used to work, since it's unscaled, but broke with:
> >>
> >>------------------------------------------------------------------------
> >>r27317 | michael | 2008-07-17 18:01:18 -0400 (Thu, 17 Jul 2008) | 2  
> >>lines
> >>
> >>Ensure that exactly one scaler algo is used.
> >>
> >>and apparently I'm the only one who ever uses sab.
> >>Attached patch fixes it; since it's unscaled, the algorithm flag is  
> >>ignored
> >>anyway, but SWS_POINT seemed most correct.
> >
> >i assume you checked that the scaler type makes no difference?
> 
> Yes, I checked md5sum of -vf sab=4.1:.3:16 using r26045 (2008-02-20),  
> current+this patch, and current+SWS_GAUSS and they are all the same.

Remember that you can commit to MPlayer, so just apply this.

Diego



More information about the MPlayer-dev-eng mailing list