[MPlayer-dev-eng] [PATCH] Network synchronized playback using UDP

[Jason Holt]

Manpage fixed.  Thanks.


> +void send_udp(char *send_to_ip, int port, char *mesg);
>
> This is ugly, please just reorder the functions sensibly.


send_udp calls exit_player, which calls exit_player_with_rc, which calls
send_udp.


Also, I wonder if this has to be in mplayer.c, which is already big
> enough.


I'm happy to move it.  stream/udp.c is the most related source file I could
find, but it's a little weird to have it in stream/.  I could create new
.c/.h files if you think it's worthwhile.

> @@ -743,6 +766,168 @@
> >
> > +  sendto(sockfd,
> > +         mesg,
> > +         strlen(mesg),
> > +         0,
> > +         (struct sockaddr *) &socketinfo,
> > +         sizeof(socketinfo));
>
> This is ugly.
>
> > +void udp_slave_sync() {
>
> (void)


Fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-udp-patch-9.diff
Type: text/x-diff
Size: 12191 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090410/623430dc/attachment.diff>