[MPlayer-dev-eng] [PATCH] memory leak in vo_macosx

[Guillaume POIRIER]

Hello,

2009/4/9 Alexander Strange <astrange at ithinksw.com>:
> vo_macosx leaks ~80 bytes with each call to flip_page, because this line:
>        error = CVOpenGLTextureCacheCreateTextureFromImage(NULL,
> textureCache, frameBuffers[image_page], 0, &texture);
>
> overwrites 'texture' without freeing the old one first (checked with
> 'leaks'). I'm not sure when this started happening. Attached patch fixes it
> by releasing the old texture.

Thanks for the patch, but have you tested it before submitting it? I
doesn't compile! Attached patch has the changes your meant.
I've tested it on several videos, and confirmed that it didn't cause
any regression, but I'd like to use it more one real world usage to
confirm it does work as expected.

Cheers!

Guillaume

-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Emo Philips  - &quot;A computer once beat me at chess, but it was no
match for me at kick boxing.&quot; -
http://www.brainyquote.com/quotes/authors/e/emo_philips.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: macosx_leak.diff
Type: application/octet-stream
Size: 488 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090409/2dd6f308/attachment.obj>