[MPlayer-dev-eng] [PATCH]Fix Makefile dependencies for version.h

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Apr 6 16:56:54 CEST 2009


On Mon, 2009-04-06 at 13:18 +0200, Diego Biurrun wrote:
> On Sat, Apr 04, 2009 at 11:17:29PM +0200, Carl Eugen Hoyos wrote:
> > 
> > Attached is the ugly alternative to "Reduce version.h dependencies" (and 
> > the necessary followups).
> > Please don't just ignore this issue, I think fixing it makes our lives 
> > much easier.
> > 
> > Any alternatives?
> > 
> > --- Makefile	(revision 29137)
> > +++ Makefile	(working copy)
> > @@ -862,7 +862,8 @@
> >  
> >  # Make sure all generated header files are created.
> > -$(DEPS) $(MENCODER_DEPS) $(MPLAYER_DEPS): codecs.conf.h help_mp.h version.h
> > +$(DEPS) $(MENCODER_DEPS) $(MPLAYER_DEPS): codecs.conf.h help_mp.h
> > +mpcommon.d mpcommon.o vobsub.d vobsub.o stream/stream_cddb.d stream/stream_cddb.o stream/network.d stream/network.o libmpdemux/muxer_avi.d libmpdemux/muxer_avi.o gui/win32/gui.d gui/win32/gui.o: version.h
> 
> Specifying just the .d files should be enough, please try that.

Why would you want to specify the .d files there at all? Do you expect
version.h to include other headers? Wouldn't it make much more sense to
_skip_ the .d files?




More information about the MPlayer-dev-eng mailing list