[MPlayer-dev-eng] Mplayer -vo ps3
Diego Biurrun
diego at biurrun.de
Sat Apr 4 22:41:36 CEST 2009
On Sat, Apr 04, 2009 at 10:26:33PM +0200, Kristian Jerpetjøn wrote:
>
>
> I am not done with all the comments but around 80% ish is taken care of.
>
> --- Makefile (revision 29136)
> +++ Makefile (working copy)
> @@ -553,6 +553,7 @@
> SRCS_MPLAYER-$(DXR3) += libvo/vo_dxr3.c
> SRCS_MPLAYER-$(ESD) += libao2/ao_esd.c
> SRCS_MPLAYER-$(FBDEV) += libvo/vo_fbdev.c libvo/vo_fbdev2.c
> +SRCS_MPLAYER-$(PS3) += libvo/vo_ps3.c
> SRCS_MPLAYER-$(GGI) += libvo/vo_ggi.c
> SRCS_MPLAYER-$(GIF) += libvo/vo_gif89a.c
Please respect alphabetical order.
> --- libvo/vo_ps3.c (revision 0)
> +++ libvo/vo_ps3.c (revision 0)
> @@ -0,0 +1,732 @@
> +/*
> + * video driver for cell / BE Playstation3 framebuffer
> + * Copyright 2007 by Bill Garrett <wgarrett at sc.rr.com>
> + * Copyright 2009 by Kristian Jerpetj?n <kristian.jerpetjoen at gmail.com>
> + *
> + * This video out device uses the Cell Broadband Engine spes to accellerate
accelerate
> + * scaling and colorspaceconversion
colorspace conversion
> +/**
> + * Function makes a copy of inbufs to .yuv files in current directory
"Function" is redundant here, what else would it be?
> + for ( i=0; i<2; i++ )
> + {
> + snapshot = fopen ( inbuf_file[i], "wb" );
K&R for new files please, i.e. no space between function name and
opening parenthesis, opening { on the same line as the for/if/while.
> + mp_msg ( MSGT_VO, MSGL_INFO, "[vo_ps3] snapshot: wrote current inbuf_*[]"
> + "to inbuf0.yuv & inbuf1.yuv\n" );
weird indentation
> --- configure (revision 29136)
> +++ configure (working copy)
> @@ -4758,6 +4762,26 @@
>
> +if test "$_ps3" = yes; then
> + def_ps3='#define CONFIG_PS3 1'
> + libs_mplayer="$libs_mplayer -lspu-medialib -lspe2"
> + _vomodules="ps3 $_vomodules"
messed-up indentation
> @@ -8204,6 +8228,7 @@
> FAAD_INTERNAL = $_faad_internal
> FASTMEMCPY = $_fastmemcpy
> FBDEV = $_fbdev
> +PS3 = $_ps3
> FREETYPE = $_freetype
> FTP = $_ftp
> GIF = $_gif
alphabetical order
> @@ -8715,6 +8740,7 @@
> $def_dxr2
> $def_dxr3
> $def_fbdev
> +$def_ps3
> $def_ggi
> $def_ggiwmh
> $def_gif
alphabetical order
Diego
More information about the MPlayer-dev-eng
mailing list