[MPlayer-dev-eng] [PATCH] Address some sizing related glitches in vo_direct3d

[Reimar Döffinger]

On Thu, Apr 02, 2009 at 03:56:06PM -0400, David Bolen wrote:
> David Bolen <db3l.net at gmail.com> writes:
> 
> > While using vo_direct3d with mplayer in slave mode while attached to
> > an embedded window in my application, I've run into a few instances of
> > glitches or brief corruption of the display while the window is being
> > resized, especially when the video is currently paused (in which case
> > the corruption may persist until playing resumes).  There is also
> > sometimes an initial glitch when displaying into an attached window
> > that is not the same size as the video being loaded.
> >
> > The attached proposed patch helps clean up the cases I've encountered,
> > via:
> 
> Any feedback on the proposed patch?  I've been using it successfully
> (glitch-free) in production for a few weeks now.

It's probably ok, but it is a bit much in one patch, almost every hunk could
be split into a separate patch that still makes sense and would then come
with it is own commit message, making it easier to understand and also find
the cause should it introduce regressions.