[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[Reimar Döffinger]

On Thu, Apr 02, 2009 at 02:12:47PM +0200, Diego Biurrun wrote:
> On Thu, Apr 02, 2009 at 02:09:24PM +0200, Reimar Döffinger wrote:
> > On Thu, Apr 02, 2009 at 01:59:42PM +0200, Diego Biurrun wrote:
> > > On Sat, Mar 28, 2009 at 04:57:32AM +0300, Andrew Savchenko wrote:
> > > > 
> > > > 
> > > > --- configure	(revision 29079)
> > > > +++ configure	(working copy)
> > > > @@ -6589,6 +6593,43 @@
> > > >  
> > > > +    cc_check $_inc_tmp $_ld_tmp && extra_ldflags="$extra_ldflags $_ld_tmp" && \
> > > > +      extra_cflags="$extra_cflags $_inc_tmp" && _libbs2b=yes
> > > 
> > > redundant \
> > > 
> > > > --- libaf/af_bs2b.c	(revision 0)
> > > > +++ libaf/af_bs2b.c	(revision 0)
> > > > @@ -0,0 +1,215 @@
> > > > +
> > > > +    const int val=*(int*)par;
> > > 
> > > extra good karma for spaces around the =.
> > > 
> > > No more comments from me, approving this now depends on others.
> > 
> > IIRC I did approve it already. I probably could find some nitpicks like
> > yours above if I wanted, but that's not worth it I think.
> 
> I wouldn't even haven mentioned them if I didn't have to write a mail
> anyway to voice my approval.

Just to clarify: My comment wasn't meant as a criticism, and I agree
with your "nitpicks", I was just stating my view of the state of the patch.