[MPlayer-dev-eng] [PATCH] libbs2b audio filter

[bircoph at gmail.com]

On Saturday 28 March 2009, Andrew Savchenko wrote:
> Hi,
>
> On Friday 27 March 2009 01:18, Diego Biurrun wrote:
> [...]
>
> > > > This patch reminded me, why do we still have this af_msg
> > > > special-casing?
> > >
> > > I have absolutely no idea. It is defined at af.h, it is not
> > > marked as deprecated, it is used widely in other peaces of
> > > code; so I used it for consistency.
> > >
> > > Now I replaced them by mp_msg, because newly introduced
> > > af_stats filter do the same. Perhaps af_msg should be
> > > declared deprecated and removed from other audio filters.
> >
> > Any volunteers to remove all of them? :)
>
> Will do this later as a separate patch.
>
> > > --- configure	(revision 29067)
> > > +++ configure	(working copy)
> > > @@ -6589,6 +6593,45 @@
> > >
> > > +  if $_pkg_config --exists libbs2b ; then
> >
> > Gah, pkg-config..
>
> ???
> As of svn r.29079 it is still _pkg_config, not pkg_config.
> Variable usage instead of direct binary call is sufficient,
> because $_pkg_config == false if this utility is not present on
> the target system.
>
> > > +    cc_check $_inc_tmp $_ld_tmp &&
> > > extra_ldflags="$extra_ldflags $_ld_tmp" \ +
> > > extra_cflags="$extra_cflags $_inc_tmp" && _libbs2b=yes
> >
> > Missing && ?
>
> Yes :)
>
> > > +def_libbs2b="#undef CONFIG_LIBBS2B"
> > > +if test "$_libbs2b" = yes; then
> > > +  def_libbs2b="#define CONFIG_LIBBS2B"
> > > +fi
> >
> > You can save two lines with && here.
>
> ok
>
> > > --- libaf/af_bs2b.c	(revision 0)
> > > +++ libaf/af_bs2b.c	(revision 0)
> > > @@ -0,0 +1,215 @@
> > > +/*
> > > + * This filter adds support for the Bauer
> > > stereophonic-to-binaural + * DSP using bs2b library:
> > > http://bs2b.sourceforge.net/
> >
> > "This filter adds support for" is completely redundant.
> >
> > Compare
> >
> >   This sentence tells you that what you wrote is redundant.
> >
> > vs.
> >
> >   What you wrote is redundant.
>
> Fixed.

Ping.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090402/5b6e2bd2/attachment.pgp>