[MPlayer-dev-eng] [PATCH] Patch for better pause support.

Robert Cummings robert at interjinn.com
Fri Sep 26 09:25:16 CEST 2008


On Fri, 2008-09-26 at 09:03 +0200, Reimar Döffinger wrote:
> On Thu, Sep 25, 2008 at 11:29:41PM -0400, Robert Cummings wrote:
> > I think my original patch without pausing_keep_force (while
> > certainly not perfect) was superior in the sense that it provided the
> > desired functionality without forking the command system into a third
> > mode.
> 
> IMHO it provided the functionality you desired, not what I desired (a
> system that works in general), e.g. I saw no easy way to extend your
> method to work with the get_/set_property stuff, which in the future is
> supposed to be the main method.
> The current solution is supposed to be a simple method to provide the
> functionality and help gain some experience that hopefully helps to get
> to a proper solution.

Well the original patch allowed addressing each command individually to
determine whether said command would benefit from properly maintaining
pause. I only applied it to two commands, the one I was most interested
in, and the one I added so that others could be addressed via
discussion. As a matter of implementation, I had intended it to have
general applicability on a case by case basis where appropriate.

I'm not familiar with the get_/set_property stuff. I'll have a look to
acquaint myself with the issues. Thanks for the response.

Cheers,
Rob.
-- 
http://www.interjinn.com
Application and Templating Framework for PHP




More information about the MPlayer-dev-eng mailing list