[MPlayer-dev-eng] PATCH - Resubmitting get_property chapters patch

Kevin DeKorte kdekorte at gmail.com
Mon Sep 22 22:13:06 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nico Sabbi wrote:
| Il giorno lun, 22/09/2008 alle 14.05 -0600, Kevin DeKorte ha scritto:
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA1
|>
|> Nico Sabbi wrote:
|> | Il giorno lun, 22/09/2008 alle 21.49 +0200, Mathieu SCHROETER ha
|> | scritto:
|> |
|> |> Here, It is possible, see here:
|> |>
|> |>
|>
http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2008-August/035184.html
|> |>
|> |> Regards,
|> |> Mathieu
|> |
|> | it's a different thing: the slave mode doesn't initialize a demuxer,
|> | but a demuxer (unless I'm missing something of the recent development)
|> | still can't exist without a stream
|>
|> The checks where put in for safety and to keep the application from
|> crashing. I know it shouldn't be possible for them to be NULL, but this
|> ensures it.
|>
|> Better safe than sorry when dealing with NULL pointers.
|>
|> Kevin
|>
|
| wrong point of view: unneeded checks hide bugs, and hiding bugs
| worsens the quality of the code
|

Ok, so if I take out the checks and resubmit the patch, will you merge
it in? If so I'll have the patch to you as soon as you say yes.

Kevin
- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFI1/xS6w2kMH0L1dERAoU3AKCQ4b5Mz/rFSxB8ykW0dEw4o5IgVgCfYnC9
TL2pidmHPMgv3+jvsdlLTj8=
=Pojo
-----END PGP SIGNATURE-----



More information about the MPlayer-dev-eng mailing list