[MPlayer-dev-eng] MNG support for MPlayer

[Stefan Schuermans]

Diego Biurrun wrote:
> On Tue, Sep 16, 2008 at 09:36:42PM +0200, Stefan Schuermans wrote:
>> --- trunk/configure	2008-09-16 16:41:32.000000000 +0200
>> +++ mng/configure	2008-09-16 16:40:32.000000000 +0200
>> @@ -4675,6 +4679,39 @@
>>  
>> +echocheck "MNG support"
>> +if test "$_mng" = auto ; then
>> +  _mng=no
>> +  if irix ; then
>> +    # Don't check for -lmng on irix
>> +    _res_comment="disabled on irix"
> 
> Did you verify this or is it just copied and pasted (and thus
> guesswork) from the PNG test?

You got me, I copied this from the PNG auto detection, but I spent a 
(short) thought on the irix stuff. I was not sure how to deal with MNG 
on irix, so I first thought to not break anything on irix and just skip 
MNG because MNG is based on PNG and PNG seems to be problematic on irix.

But now I've checked the libmng documentation again in more detail. It 
states states that libmng does not use libpng, so it's not sure there 
are problems with libmng on irix. I removed the "if" skipping the test 
for irix.

>> +cat > $TMPC << EOF
>> +#include <libmng.h>
>> +#include <string.h>
>> +int main(void) {
>> +  const char * p_ver = mng_version_text() ?: "";
>> +  printf("libmng: %s\n", p_ver);
>> +  return p_ver[0] == 0;
>> +}
> 
> You do not seem to be using string.h.

You're right, I removed that.

I also removed the __attribute__((unused)), converted the code to not 
contain any lines longer than 78 characters and corrected the typos.

Regarding the issue with variable framerate, I now understood how the 
GIF demuxer does the variable framerate and switched the MNG demuxer to 
the same mechanism.

Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MPlayer-svn20080918-mng.diff
Type: text/x-patch
Size: 22474 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080918/91a87345/attachment.bin>