[MPlayer-dev-eng] Patch - get_property chapters

compn tempn at twmi.rr.com
Thu Sep 18 15:50:54 CEST 2008


On Thu, 18 Sep 2008 07:34:07 -0600, Kevin DeKorte wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>compn wrote:
>| On Tue, 16 Sep 2008 15:06:08 -0600, Kevin DeKorte wrote:
>|> [chapters_property.diff  text/x-patch (1016B)]
>|> Index: command.c
>|>     { "chapter", mp_property_chapter, CONF_TYPE_INT,
>|>      M_OPT_MIN, 1, 0, NULL },
>|> +    { "chapters", mp_property_chapters, CONF_TYPE_INT,
>|> +     0, 0, 0, NULL },
>|
>| actually, get_property chapter works. read command.c chapter area.
>| or read slave.txt , the table says chapter supports get/set/step
>|
>| chapter            int       0               X   X   X    select chapter
>|
>| get_property chapter
>| ANS_chapter=0
>|
>| patch rejected. unless your patch does something else?
>|
>| -compn
>
>No, get_property chapter tells you what chapter you are viewing. Get
>property chapters tells you how many chapters are present.
>
>So no it is not the same thing. Please apply patch.
>

ah, oops.
i shouldnt be reviewing patches.
ignore my other mail too.

-compn



More information about the MPlayer-dev-eng mailing list