[MPlayer-dev-eng] [PATCH] Solaris support for SSE(2) autodetection

[Milan Jurik]

Hi Reimar,

V st, 17. 09. 2008 v 23:24, Reimar Döffinger píše:
> On Wed, Sep 17, 2008 at 10:30:49PM +0200, Milan Jurik wrote:
> > I don't understand. The code adds possibility for autodetection of 
> > SSE/SSE2 in runtime-cpudetection for Solaris, when it's requested (as 
> > done for other platforms already). I believe it's purpose of runtime CPU 
> > detection to detect CPU capabilities.
> 
> There is already working, perfectly portable code to detect CPU
> capabilities. The code you are modifying is for detecting if the
> operating system supports SSE/SSE2, after we already _know_ that the
> CPU supports them.
> I am not even sure there are any Solaris versions at all that do not
> support SSE/SSE2, in which case the check would be quite pointless.

Ah, this you meant. Officially SSE/SSE2 are supported from Solaris 9 (it
could be workarounded on S8 probably). Not sure if we can count Solaris
8 as relevant on multimedia desktop today. What do you prefer, automatic
enable for Solaris or uname() version test?

Best regards,

Milan