[MPlayer-dev-eng] Some small AmigaOS4 patches to compile last mplayer
Dominik 'Rathann' Mierzejewski
dominik at rangers.eu.org
Thu Sep 18 10:00:42 CEST 2008
On Thursday, 18 September 2008 at 09:47, Andrea Palmatè wrote:
> At 00.48 18/09/2008, you wrote:
>
> >Send libdvdcss patches upstream. I will no longer accept libdvdcss
> >patches now that we got rid of our local patchset and are using a
> >vanilla libdvdcss version.
>
> ok, i'll do
>
>
> >Cosmetics, tons more are below.
> >
> >This is completely unacceptable, remove the whitespace changes from your
> >patch, then we can start discussing it. I must say I'm surprised to see
> >you make this mistake, it's not the first patch you propose...
>
> Eh Diego.. i'm no the guilty.. the guilty is the svn command on
> cygwin that for some stupid reason think that unix/win line end are changes..
> i didn't see the entire diff file and so i was thinking that the
> changes was correct
>
> i'll use macosx to produce the diff file.. i'm sorry..
Try to make svn tell diff to ignore whitespace changes:
svn diff -x -w
Also, you should always check your patches before sending them. ;)
Regards,
R.
--
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan
More information about the MPlayer-dev-eng
mailing list