[MPlayer-dev-eng] Some small AmigaOS4 patches to compile last mplayer

Diego Biurrun diego at biurrun.de
Wed Sep 17 19:45:37 CEST 2008


On Wed, Sep 17, 2008 at 06:18:33PM +0200, Andrea Palmatè wrote:
> attached some small patches to configure & compile mplayer on amigaos4
> hope you can apply them

No, I cannot.

> --- libdvdcss/ioctl.h	(revision 27632)
> +++ libdvdcss/ioctl.h	(working copy)

Send libdvdcss patches upstream.  I will no longer accept libdvdcss
patches now that we got rid of our local patchset and are using a
vanilla libdvdcss version.

> --- mplayer.c	(revision 27632)
> +++ mplayer.c	(working copy)
> @@ -256,8 +256,8 @@
>  // codecs:
>  char **audio_codec_list=NULL; // override audio codec
>  char **video_codec_list=NULL; // override video codec
> -char **audio_fm_list=NULL;    // override audio codec family 
> -char **video_fm_list=NULL;    // override video codec family 
> +char **audio_fm_list=NULL;    // override audio codec family
> +char **video_fm_list=NULL;    // override video codec family

Cosmetics, tons more are below.

This is completely unacceptable, remove the whitespace changes from your
patch, then we can start discussing it.  I must say I'm surprised to see
you make this mistake, it's not the first patch you propose...

Diego



More information about the MPlayer-dev-eng mailing list