[MPlayer-dev-eng] [RFC] towards working shared libav* support, part 2

[Reimar Döffinger]

On Sun, Sep 14, 2008 at 03:51:48AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> Additionally, it needs
> svn cp ffmpeg/libavutil/bswap.h mplayer/osdep/bswap.h
> svn cp ffmpeg/libavutil/intreadwrite.h mplayer/osdep/intreadwrite.h
> (with minor adjustments, skipped for now)

I have quite a problem with that. That is exactly the kind of code I
really would _not_ want to have duplicated, and doubly not with the same
file name, IMO that kind of thing caused enough issues in the past (even
though the make system has improved so it is less of an issue).

> Index: mpintrw.h
> ===================================================================
> --- mpintrw.h	(revision 0)
> +++ mpintrw.h	(revision 0)
> @@ -0,0 +1,11 @@
> +#ifndef MPLAYER_MPINTRW_H
> +#define MPLAYER_MPINTRW_H
> +
> +#include "config.h"
> +#ifdef CONFIG_LIBAVUTIL_A
> +#include "avutil/intreadwrite.h"

Huh? did you test that?

> +#else
> +#include "osdep/intreadwrite.h"
> +#endif
> +
> +#endif /* MPLAYER_MPINTRW_H */

And since it is a wrapper for intreadwrite.h it should be called
mpintreadwrite.h, not mpintrw.h - if the name seems too verbose
to you, FFmpeg is the place to get it changed IMHO.

Greetings,
Reimar Döffinger