[MPlayer-dev-eng] [PATCH] external liba52 support

[Diego Biurrun]

On Sat, Sep 13, 2008 at 04:00:26PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Saturday, 30 August 2008 at 01:00, Dominik 'Rathann' Mierzejewski wrote:
> > On Saturday, 30 August 2008 at 00:48, Diego Biurrun wrote:
> > > On Fri, Aug 22, 2008 at 02:14:23AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > Here are two patches which add external liba52-0.7.4 support.
> > > 
> > > This is very welcome, thanks.
> > > 
> > > > Patch1: conditionalizes enabling of some acceleration because
> > > > liba52-0.7.4 doesn't support all that MPlayer's copy does.
> > > > Patch2: the main patch, depends on Patch1
> > > > 
> > > > Tested with --disable-liba52-internal and without, seems to be working fine.
> 
> Updated patches against current SVN attached.
> 
> OK to apply?

Some small comments below, the rest is OK from me.

> --- configure	(revision 27599)
> +++ configure	(working copy)
> @@ -6068,10 +6072,33 @@
>  
> +if test "$_liba52_internal" = yes ; then
> +  _def_liba52_internal="#define CONFIG_LIBA52_INTERNAL 1"
> +  _res_comment="internal"
> +  _liba52=yes
> +elif test "$_liba52" = yes ; then
> +  _ld_extra="$_ld_extra -la52"
> +  _res_comment="external"
> +  _liba52=yes

The last line is redundant, you have just checked that _liba52 is set to
yes...

> +else
> +  _def_liba52_internal="#undef CONFIG_LIBA52_INTERNAL"
> +  _liba52=no
> +fi
>  if test "$_liba52" = yes ; then
>    _def_liba52='#define CONFIG_LIBA52 1'
> -  _codecmodules="liba52 $_codecmodules"
> +  _codecmodules="liba52($_res_comment) $_codecmodules"
>  else
>    _def_liba52='#undef CONFIG_LIBA52'
>    _nocodecmodules="liba52 $_nocodecmodules"

Ideally these two if blocks should be merged.  If you cannot do it
quickly, leave it and commit, I will look into it later myself then.

Diego