[MPlayer-dev-eng] Fix the bug of -vo xv mode when use switch_ratio

The Wanderer inverseparadox at comcast.net
Tue Sep 9 16:19:13 CEST 2008


Reimar Döffinger wrote:

> On Tue, Sep 09, 2008 at 09:08:13AM -0400, The Wanderer wrote:
> 
>> I think it unlikely that this particular change would be accepted
>> in any case, since there's no point to it and it breaks vertical
>> alignment.
> 
> Hm, does that mean you can explain what it does and what that is
> supposed to be good for? Because I don't know...

I was actually referring to just that specific hunk (and indirectly to
the others like it in the same patch) - because after all just adding
one space to the indentation of a correctly-indented open-square-brace
doesn't seem to have much point to it.

Now that I look at the rest of the patch more closely, it seems to be
flooded with cosmetics, and almost unreadable as a result. Some of those
cosmetics might be desirable on their own (the next-to-final hunk just
corrects the indentation of the code in that block), but certainly
should not be combined with other changes.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.



More information about the MPlayer-dev-eng mailing list